fix: Set namespace for AppProjects and repositories #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
+ Coverage 44.52% 44.62% +0.10%
==========================================
Files 90 90
Lines 11909 11926 +17
==========================================
+ Hits 5302 5322 +20
+ Misses 6174 6170 -4
- Partials 433 434 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chetan-rns
reviewed
Sep 18, 2025
chetan-rns
reviewed
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
The AppProject and Repository Credentials management of both agent and principal do not set the namespace properly. Thus, syncing those resources works only when principal and agent are running in the same namespace (i.e. "argocd" or similar).
This PR sets the namespace explicitly to the principal's or agent's namespace before trying to create/update/delete said resources.
Which issue(s) this PR fixes:
Fixes #570
How to test changes / Special notes to the reviewer:
Checklist